Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] HTML output doesn't work well in mobile #2347

Closed
jimlyas opened this issue Feb 7, 2022 · 3 comments · Fixed by #2836
Closed

[BUG] HTML output doesn't work well in mobile #2347

jimlyas opened this issue Feb 7, 2022 · 3 comments · Fixed by #2836
Labels
bug format: html An issue/PR related to Dokka's default HTML output format

Comments

@jimlyas
Copy link

jimlyas commented Feb 7, 2022

Describe the bug
When opened from mobile devices, the page have features like when opened through desktop.

The other thing is it doesn't have toggle to switch between light and dark theme like desktop when opened with mobile.

Expected behaviour
The page doesn't have dark/light theme switches, and the menu just plain white

Screenshots
image
image

To Reproduce
Just build your applicatioin using dokkaHtmlMultiModule and display it with mobile devices

Dokka configuration
Configuration of dokka used to reproduce the bug

tasks.withType(DokkaMultiModuleTask::class.java).configureEach {
        moduleName.set("DevBase")
        outputDirectory.set(file("$rootDir/docs/src/reference"))
        pluginConfiguration<DokkaBase, DokkaBaseConfiguration> {
            footerMessage = "© 2021 Telkom DEV"
            customAssets = listOf(file("logo-icon.svg"))
        }
}

Installation

  • Operating system: Windows
  • Build tool: Gradle v7.0.2
  • Dokka version: 1.6.10

Additional context
Please support GFM format too, I see many improvement in HTML format but not in GFM. Thanks

Are you willing to provide a PR?
No.

@jimlyas jimlyas added the bug label Feb 7, 2022
@jimlyas jimlyas changed the title HTML doesn't work well in mobile [BUG] HTML output doesn't work well in mobile Jun 18, 2022
@IgnatBeresnev IgnatBeresnev added the format: html An issue/PR related to Dokka's default HTML output format label Mar 8, 2023
@IgnatBeresnev IgnatBeresnev linked a pull request Mar 8, 2023 that will close this issue
@robstoll
Copy link
Contributor

workaround for menu on mobile:

/* fix for dokka, wrong colors in dark-mode */
@media screen and (max-width: 759px) {
    :root.theme-dark #container #leftColumn {
        background: var(--background-color);
    }
    :root.theme-dark #leftToggler {
        color: var(--default-font-color);
    }
}

@IgnatBeresnev
Copy link
Member

The problem with the menu is fixed in #2836, and it's going to be released in 1.9.0

I've created a separate issue for the missing theme switcher button: #3000

@IgnatBeresnev
Copy link
Member

The issue has been fixed, and it will be released in 1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug format: html An issue/PR related to Dokka's default HTML output format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants