Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jsoup to 1.14.3 #2448

Merged
merged 4 commits into from Apr 19, 2022
Merged

Update Jsoup to 1.14.3 #2448

merged 4 commits into from Apr 19, 2022

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Apr 18, 2022 •
edited

Maven central is giving a big warning about a vulnarability

This ought to fix it

2022-04-18_20-59-52

@IgnatBeresnev
Copy link
Member Author

JSoup has had some API changes:

  • Better support for nullability. They've marked methods with @Nullable and @NotNull, so build started failing due to compilation error (needed to add some checks for tests). Also, Qodana asked me to remove some excessive null checks
  • They've added element.first() and element.last() methods, which clashses with Kotlin's collections.first() and collections.last() methods.

@IgnatBeresnev IgnatBeresnev merged commit 3d57382 into master Apr 19, 2022
@IgnatBeresnev IgnatBeresnev deleted the jsoup-cve-update branch April 19, 2022 10:11
IgnatBeresnev added a commit that referenced this pull request Apr 21, 2022
@IgnatBeresnev
Update Jsoup to 1.14.3 (#2448)
68eaffc 
* Update Jsoup to 1.14.3

* Fix Jsoup API breaking changes after the update

* Fix new Qodana inspections

* Replace IllegalStateException with more appropriate NoSuchElementException

(cherry picked from commit 3d57382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmishenev vmishenev vmishenev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IgnatBeresnev @vmishenev