Do not expose kotlin stdlib in the Gradle plugin dependencies #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
approved these changes
Jun 21, 2022
| @@ -30,6 +30,15 @@ dependencies { | |||
| ) | |||
| } | |||
|
|
|||
| // Gradle will put its own version of the stdlib in the classpath, do not pull our own we will end up with | |||
| // warnings like 'Runtime JAR files in the classpath should have the same version' | |||
| configurations.api { | |||
There was a problem hiding this comment.
It excludes stdlib from :core dependency.
So stdlib will be taken from gradleApi (that is added by java-gradle-plugin)
There was a problem hiding this comment.
Indeed. Note I'm not 100% certain how gradleApi works (e.g. it doesn't show kotlin-stdlib in ./gradlew dependencies even if it's there)
Also I just realize I forgot kotlin-stdlib-common, I just pushed it.
IgnatBeresnev
approved these changes
Jun 21, 2022
|
Will be released in 1.7.10, thanks once again! |
IgnatBeresnev
pushed a commit
that referenced
this pull request
Jul 11, 2022
(cherry picked from commit 3f4336d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Gradle will put its own Kotlin stdlib in the classpath, it's no use adding it as a transitive dependency. It might even cause compilation errors.
See https://kotlinlang.slack.com/archives/C0F4UNJET/p1655743911527999