Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source link to the line with name #2724

Merged
merged 4 commits into from Oct 26, 2022
Merged

Fix source link to the line with name #2724

merged 4 commits into from Oct 26, 2022

Conversation

vmishenev
Copy link
Member

No description provided.

IgnatBeresnev
IgnatBeresnev approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The only thing is if there's an annotation on top of a class/method, source link will lead to the line with the annotation, not the name. Either PR's title or behaviour needs to be corrected to avoid confusion, as at the moment it's not 100% accurate

@vmishenev vmishenev merged commit d1b2498 into master Oct 26, 2022
@vmishenev vmishenev deleted the souce-link-first-line branch October 26, 2022 18:07
atyrin pushed a commit that referenced this pull request Nov 1, 2022
@vmishenev @atyrin
Fix source link to the line with name (#2724)
b560a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnatBeresnev IgnatBeresnev Awaiting requested review from IgnatBeresnev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmishenev @IgnatBeresnev