Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce jackson-databind constraint for 2.12.7.1 #2733

Merged
merged 2 commits into from Nov 10, 2022

Conversation

ryanlewis
Copy link
Contributor

Fixes CVE-2022-42003 without going to 2.13.X branch.

@ryanlewis ryanlewis changed the title Bumped Jackson to 2.12.7.1 Bump Jackson to 2.12.7.1 Oct 31, 2022
@IgnatBeresnev
Copy link
Member

Thanks for noticing and submitting the PR!

It looks like this version exists for jackson-databind only, and doesn't exist for jackson-module-kotlin, which causes build problems since the property is re-used, see CI logs

I think we can introduce a separate property jackson_databind_version for a limited time and add an explicit dependency on jackson-databind, at least until the next update in which it'll be synced

Do you have the time to implement that?

@ryanlewis
Copy link
Contributor Author

@IgnatBeresnev thanks, will take a look, shouldn't take long

@ryanlewis ryanlewis changed the title Bump Jackson to 2.12.7.1 Introduce jackson-databind constraint for 2.12.7.1 Nov 7, 2022
@IgnatBeresnev IgnatBeresnev self-requested a review November 9, 2022 13:41
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you so much!

I'll start lengthy integration tests which should take a few hours to complete, and we'll merge if they pass

@IgnatBeresnev
Copy link
Member

JFYI integration tests failed due to a different problem with androidx documentation, it should be fixed soon and I'll re-run it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants