Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non deterministic sorting of merged extensions/properties #2784

Closed
IgnatBeresnev opened this issue Dec 21, 2022 · 0 comments · Fixed by #2846
Closed

Non deterministic sorting of merged extensions/properties #2784

IgnatBeresnev opened this issue Dec 21, 2022 · 0 comments · Fixed by #2846
Assignees
@IgnatBeresnev
Labels
bug feedback: Kotlin libs Feedback from Kotlin's internal libraries

Comments

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Dec 21, 2022 •
edited

Merged extension properties that have the same name and the same signature are sorted nondeterministically, leading to non-reproducible builds.

This makes it difficult to compare outputs of different versions/runs of Dokka since it adds noise to the comparison.

Screenshots

image

image
@IgnatBeresnev IgnatBeresnev added bug feedback: Kotlin libs Feedback from Kotlin's internal libraries labels Dec 21, 2022
@IgnatBeresnev IgnatBeresnev self-assigned this Dec 21, 2022
@IgnatBeresnev IgnatBeresnev changed the title Non deterministic sorting of extension functions Non deterministic sorting of merged extensions/properties Dec 21, 2022
IgnatBeresnev added a commit that referenced this issue Feb 6, 2023
@IgnatBeresnev
Sort divergent elements deterministically
3d54352 
Fixes #2784
@IgnatBeresnev IgnatBeresnev mentioned this issue Feb 6, 2023
Merged
IgnatBeresnev added a commit that referenced this issue Feb 10, 2023
@IgnatBeresnev
Sort divergent elements deterministically (#2846)
e2351eb 
Fixes #2784
@vmishenev vmishenev mentioned this issue Jul 24, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnatBeresnev IgnatBeresnev

Labels
bug feedback: Kotlin libs Feedback from Kotlin's internal libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort divergent elements deterministically Kotlin/dokka
1 participant
@IgnatBeresnev