Gradle Plugin: update custom Gradle utils to use Gradle Kotlin DSL #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aSemy
changed the title
IgnatBeresnev
added
the
runner: Gradle plugin
aSemy
force-pushed
the
feat/update_gradle_utils_with_kotlin_dsl
branch
from
47010c2
to
42c6cc4
Compare
IgnatBeresnev
approved these changes
Feb 22, 2023
...-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/GradleExternalDocumentationLinkBuilder.kt
Show resolved
Hide resolved
runners/gradle-plugin/src/main/kotlin/org/jetbrains/dokka/gradle/tasks/DokkaCollectorTask.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2700
This PR removes some of the custom Gradle utility functions that are now provided by the Gradle Kotlin DSL.
getSafe()➡️get(), ororNullsafeProperty()➡️org.gradle.kotlin.dsl.property()safeConvention()➡️convention()The benefit is closer alignment with the Gradle API, and more idiomatic code that helps with working with the Gradle plugin, as the code can be understood without needing to know about the custom utilities specific to Dokka.
This PR is similar to #2706.
Depends on