Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always display sourceset/platform indicators in the header/packages #2847

Closed
IgnatBeresnev opened this issue Feb 6, 2023 · 0 comments · Fixed by #2848
Closed

Always display sourceset/platform indicators in the header/packages #2847

IgnatBeresnev opened this issue Feb 6, 2023 · 0 comments · Fixed by #2848
Assignees
@IgnatBeresnev
Labels
enhancement An issue for a feature or an overall improvement feedback: Kotlin libs Feedback from Kotlin's internal libraries

Comments

@IgnatBeresnev
Copy link
Member

The sourceset/platform information is not shown in single-platform projects and single-platform/sourceset modules, so it is difficult to tell sometimes for which platform a particular library is written.

Examples:

Proposal

We can always render sourceset/platform selectors/indicators both in the header and right next to the package. However, DO NOT display the source set tab above signatures, as there is only one choice. This way, the reader has a chance of figuring out what platform the library is written for.

Examples:

2023-02-06_13-38-39

2023-02-06_13-39-01
@IgnatBeresnev IgnatBeresnev added enhancement An issue for a feature or an overall improvement feedback: Kotlin libs Feedback from Kotlin's internal libraries labels Feb 6, 2023
@IgnatBeresnev IgnatBeresnev self-assigned this Feb 6, 2023
IgnatBeresnev added a commit that referenced this issue Feb 6, 2023
@IgnatBeresnev
Display source set / platform indicators at all times
a84cb9d 
Fixes #2847
@IgnatBeresnev IgnatBeresnev mentioned this issue Feb 6, 2023
Merged
IgnatBeresnev added a commit that referenced this issue Feb 10, 2023
@IgnatBeresnev
Display source set / platform indicators at all times
59fae39 
Fixes #2847
IgnatBeresnev added a commit that referenced this issue Feb 10, 2023
@IgnatBeresnev
Display source set / platform indicators at all times (#2848)
f515abc 
Fixes #2847
This was referenced Mar 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnatBeresnev IgnatBeresnev

Labels
enhancement An issue for a feature or an overall improvement feedback: Kotlin libs Feedback from Kotlin's internal libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display source set / platform indicators at all times Kotlin/dokka
1 participant
@IgnatBeresnev