Sort groups of divergent elements by their key first ignoring case, then preserving it #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
force-pushed
the
ig/group-sorting
branch
2 times, most recently
from
d3ac5f2
to
12b71bf
Compare
ilya-g
commented
Feb 15, 2023
plugins/base/src/main/kotlin/translators/documentables/DefaultPageCreator.kt
Show resolved
Hide resolved
…hen preserving it
ilya-g
force-pushed
the
ig/group-sorting
branch
from
12b71bf
to
6dc1457
Compare
ilya-g
force-pushed
the
ig/group-sorting
branch
from
6dc1457
to
4b43955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sorting groups just by name leads to the following order:
getElementNSgetElementNamewhich is inconsistent with the sorting order in the navigation bar.
After this change, the order will be:
getElementNamegetElementNSbut if we add
getElementNsto that, it would be strictly aftergetElementNS