Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresolved link to declaration from another source set #2878

Merged
merged 2 commits into from Feb 28, 2023
Merged

Fix unresolved link to declaration from another source set #2878

merged 2 commits into from Feb 28, 2023

Conversation

vmishenev
Copy link
Member

@vmishenev vmishenev commented Feb 17, 2023 •
edited

Also, it fixed a weird link to Enum.name in stdlib since there are a lot of anchors to Enum.name.

@vmishenev vmishenev linked an issue Feb 17, 2023 that may be closed by this pull request
Unresolved link to a declaration from another source set #2877
Closed
IgnatBeresnev
IgnatBeresnev reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an explanation for what the bug was technically? I assume setOf(it) fixed it, but I don't understand what the problem was initially and how it helped

plugins/base/src/main/kotlin/resolvers/local/DokkaLocationProvider.kt Outdated Show resolved Hide resolved
@vmishenev vmishenev force-pushed the 2877-unresolved-link-to-another-source-set branch from 3129dbe to 80120f2 Compare February 21, 2023 15:37
@vmishenev vmishenev force-pushed the 2877-unresolved-link-to-another-source-set branch from 4b87328 to 76d8ed8 Compare February 28, 2023 15:25
@vmishenev vmishenev merged commit 8e31355 into master Feb 28, 2023
@vmishenev vmishenev deleted the 2877-unresolved-link-to-another-source-set branch February 28, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnatBeresnev IgnatBeresnev IgnatBeresnev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unresolved link to a declaration from another source set
2 participants
@vmishenev @IgnatBeresnev