Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up .gitignore files #2910

Merged
merged 2 commits into from Mar 9, 2023
Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Mar 8, 2023

  • Removed unnecessary ignores for
    • Maven
    • Android
    • .idea/ subdirectories (.idea/ is already ignored)
    • old Gradle files (there's no Gradle UI any more, or task-cache file)
  • Removed ignores for project files that don't exist any more

Comment on lines -1 to -2
base/src/main/resources/dokka/scripts/main.js
base/src/main/resources/dokka/scripts/main.js.map
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file duplicated the ignores in:

src/main/resources/dokka/scripts/main.js
src/main/resources/dokka/scripts/main.css
src/main/resources/dokka/scripts/main.js.map
src/main/resources/dokka/scripts/highlight-*
src/main/resources/dokka/scripts/vendors~*
search-component/dist/
/src/main/resources/dokka/styles/main.css

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know you could have non-root gitignore files 😮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they're nice because if there's something very specific that should be ignored then they're (slightly) more likely to be kept up to date as the project evolves

@IgnatBeresnev IgnatBeresnev self-requested a review March 9, 2023 11:40
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must've been a template, with things added to the end as time went on, thus the duplicates. I agree that the less unnecessary/confusing things, the better 👍 Thanks!

.gitignore Outdated Show resolved Hide resolved
@IgnatBeresnev IgnatBeresnev merged commit 13ec971 into Kotlin:master Mar 9, 2023
@aSemy aSemy deleted the tidy/git_ignores branch March 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants