Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reproducible archive build config #2947

Merged
merged 1 commit into from Mar 29, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Mar 28, 2023

infrastructure Everything related to builds tools, CI configurations and project tooling

This PR adds reproducible archive build config

This helps Gradle caching and improves build speed.

I tested this by

  1. update dokka_version to be 1.8.20 (just so long as it's not a SNAPSHOT - otherwise the comparison below is impossible)
  2. publishing to MavenProjectLocal
    ./gradlew publishAllPublicationsToMavenProjectLocalRepository
  3. rename $rootDir/build/maven-project-local to $rootDir/build/maven-project-local-tmp
  4. re-run
    ./gradlew publishAllPublicationsToMavenProjectLocalRepository
  5. comparing (with IntelliJ) $rootDir/build/maven-project-local with $rootDir/build/maven-project-local-tmp, and see that the only changes are the maven-metadata.xml timestamp
    image

Repeating the same test on master test reveals that some JARs change, even if the source code does not.

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproducible builds would be nice to have 👍 Thanks

@IgnatBeresnev IgnatBeresnev merged commit e26fc06 into Kotlin:master Mar 29, 2023
26 checks passed
@aSemy aSemy deleted the feat/reproducible_build_config branch March 29, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants