Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K2] KDoc links for extensions are unresolved #3234

Closed
vmishenev opened this issue Oct 18, 2023 · 4 comments · Fixed by #3563
Closed

[K2] KDoc links for extensions are unresolved #3234

vmishenev opened this issue Oct 18, 2023 · 4 comments · Fixed by #3563
Assignees
@vmishenev
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone
Dokka 2.0.0

Comments

@vmishenev
Copy link
Member

vmishenev commented Oct 18, 2023 •
edited

It results that generated documentation has plain text instead of a link to an extension , e.g. [A.someExtension()].
It is blocked by KTIJ-25454
@vmishenev vmishenev added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Oct 18, 2023
@vmishenev vmishenev changed the title [K2] KDoc links for extension are unresolved [K2] KDoc links for extensions are unresolved Oct 18, 2023
@vmishenev vmishenev added this to the Dokka 1.9.20 milestone Oct 18, 2023
@IgnatBeresnev
Copy link
Member

Note: add some basic tests for extensions

@IgnatBeresnev IgnatBeresnev added the upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler label Oct 20, 2023
@IgnatBeresnev IgnatBeresnev mentioned this issue Nov 10, 2023
Closed
@IgnatBeresnev IgnatBeresnev mentioned this issue Dec 5, 2023
Open
@IgnatBeresnev IgnatBeresnev mentioned this issue Dec 12, 2023
Open
31 tasks
@IgnatBeresnev
Copy link
Member

The upstream issue has been fixed, so we are not blocked now

@IgnatBeresnev IgnatBeresnev removed the upstream bug An issue that appears due to an upstream dependency bug, such as kotlin-compiler label Feb 23, 2024
@IgnatBeresnev
Copy link
Member

This has been unblocked and fixed upstream, just need to check it and write a test

@vmishenev vmishenev self-assigned this Apr 6, 2024
@vmishenev vmishenev linked a pull request Apr 11, 2024 that will close this issue
Add more unit tests for KDoc links #3563
Merged
@atyrin
Copy link
Contributor

atyrin commented May 3, 2024 •
edited

There is still a difference in K1 and K2 with references like [A.someExtension()] (with brackets)
K1
image
K2
image

But K1 reference leads to the same page as receiver.

For [A.someExtension] everything is fine.

@vmishenev vmishenev mentioned this issue May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmishenev vmishenev

Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Milestone
Dokka 2.0.0
Development

Successfully merging a pull request may close this issue.

Add more unit tests for KDoc links Kotlin/dokka
3 participants
@atyrin @vmishenev @IgnatBeresnev