Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API methods are private starting from 0.10.0 #534

Closed
Den-Rimus opened this issue Dec 5, 2019 · 2 comments
Closed

Some API methods are private starting from 0.10.0 #534

Den-Rimus opened this issue Dec 5, 2019 · 2 comments
Labels
Milestone

Comments

@Den-Rimus
Copy link

Is your feature request related to a problem? Please describe
Plugin users left out with no ability to customise documentation by subclassing DokkaPlugin and/or DokkaTask classes - all their essential methods were made private starting from 0.10.0 version. Why?

We had perfectly working 'document whitelisted classes only' approach before set up in our project, with modified logic of collectSuppressedFiles method in DokkaTask. Now it is private and we can't override a thing.

Describe the solution you'd like
Make key methods of plugin and task protected open

Describe alternatives you've considered
Stuck with using dokka 0.9.18 for kotlin classes only (there are some bugs in that version when applying dokka to mixed java&kotlin sourceSet - not an option) and separate javadoc task for java classes. Making the output contain two documentations, instead of all docs in one place.

@Den-Rimus Den-Rimus added the enhancement An issue for a feature or an overall improvement label Dec 5, 2019
@kamildoleglo
Copy link
Contributor

This is my mistake, I rewrote most of the Gradle runner to support multiplatform projects and forgot about that. Thanks for reporting!

@kamildoleglo kamildoleglo added this to the 0.10.1 milestone Dec 10, 2019
kamildoleglo added a commit that referenced this issue Dec 18, 2019
@kamildoleglo
Copy link
Contributor

Fixed in 29a4cc7

@mshishkina mshishkina changed the title Why make API private starting from 0.10.0? Some API methods are private starting from 0.10.0 Feb 3, 2020
@mshishkina mshishkina added bug and removed enhancement An issue for a feature or an overall improvement labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants