From 08a2a6a21446826b6c2d7669d62258e5141e298f Mon Sep 17 00:00:00 2001 From: Matthew Haughton <3flex@users.noreply.github.com> Date: Sun, 15 May 2022 17:22:21 +1000 Subject: [PATCH 1/3] Remove unused jackson-annotations dependency --- runners/gradle-plugin/build.gradle.kts | 2 -- 1 file changed, 2 deletions(-) diff --git a/runners/gradle-plugin/build.gradle.kts b/runners/gradle-plugin/build.gradle.kts index 7cc5266dc9..149fc54639 100644 --- a/runners/gradle-plugin/build.gradle.kts +++ b/runners/gradle-plugin/build.gradle.kts @@ -13,8 +13,6 @@ repositories { dependencies { api(project(":core")) - val jackson_version: String by project - compileOnly("com.fasterxml.jackson.core:jackson-annotations:$jackson_version") compileOnly("org.jetbrains.kotlin:kotlin-gradle-plugin") compileOnly("com.android.tools.build:gradle:4.0.1") compileOnly(gradleApi()) From 689661777ffd042829462633f044c3c4ada7740c Mon Sep 17 00:00:00 2001 From: Matthew Haughton <3flex@users.noreply.github.com> Date: Sun, 15 May 2022 17:23:41 +1000 Subject: [PATCH 2/3] Remove redundant kotlin-reflect dependency kotlin-reflect is provided as part of the Gradle API at compile & runtime. --- runners/gradle-plugin/build.gradle.kts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/runners/gradle-plugin/build.gradle.kts b/runners/gradle-plugin/build.gradle.kts index 149fc54639..b5c5f1b16c 100644 --- a/runners/gradle-plugin/build.gradle.kts +++ b/runners/gradle-plugin/build.gradle.kts @@ -30,13 +30,6 @@ dependencies { .classpath.asFiles.first() ) ) - - constraints { - val kotlin_version: String by project - compileOnly("org.jetbrains.kotlin:kotlin-reflect:${kotlin_version}") { - because("kotlin-gradle-plugin and :core both depend on this") - } - } } val sourceJar by tasks.registering(Jar::class) { From 82febe35b79e4aae067bc992477ec52af756b78a Mon Sep 17 00:00:00 2001 From: Matthew Haughton <3flex@users.noreply.github.com> Date: Sun, 15 May 2022 17:28:46 +1000 Subject: [PATCH 3/3] Remove redundant dependencies on gradleApi This dependency is added to the "api" configuration by java-gradle-plugin, so is already available in all compile & runtime classpaths. --- runners/gradle-plugin/build.gradle.kts | 2 -- 1 file changed, 2 deletions(-) diff --git a/runners/gradle-plugin/build.gradle.kts b/runners/gradle-plugin/build.gradle.kts index b5c5f1b16c..e82941f585 100644 --- a/runners/gradle-plugin/build.gradle.kts +++ b/runners/gradle-plugin/build.gradle.kts @@ -15,10 +15,8 @@ dependencies { compileOnly("org.jetbrains.kotlin:kotlin-gradle-plugin") compileOnly("com.android.tools.build:gradle:4.0.1") - compileOnly(gradleApi()) compileOnly(gradleKotlinDsl()) testImplementation(project(":test-utils")) - testImplementation(gradleApi()) testImplementation(gradleKotlinDsl()) testImplementation("org.jetbrains.kotlin:kotlin-gradle-plugin") testImplementation("com.android.tools.build:gradle:4.0.1")