Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate version in readme doesn't work #116

Closed
lenguyenthanh opened this issue Jan 11, 2022 · 12 comments · Fixed by #124
Closed

Release candidate version in readme doesn't work #116

lenguyenthanh opened this issue Jan 11, 2022 · 12 comments · Fixed by #124
Labels

Comments

@lenguyenthanh
Copy link

lenguyenthanh commented Jan 11, 2022

When I follow the setup in readme:

plugins {
     id("org.jetbrains.kotlinx.kover") version "0.5.0-RC"
}

Gradle tasks always failed. After I downgrade kover to 0.4.0, everything is working fine.

I think the problem is we need some to add some maven repository in order to use release candidate versions.

@shanshin
Copy link
Collaborator

Hi,
may you clarify with what error the build crashes?
You may copy the error from Gradle logs

@lenguyenthanh
Copy link
Author

When I run with ./gradlew check --debug it will run forever, here is when it got stucked:

2022-01-11T12:40:41.283+0100 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationRunner] Build operation 'Apply plugin org.gradle.application to project ':app'' completed
2022-01-11T12:40:45.769+0100 [LIFECYCLE] [org.gradle.cache.internal.DefaultFileLockManager] 
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:45.769+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:45.770+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:40:55.765+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:41:05.766+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2022-01-11T12:41:05.767+0100 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.

@shanshin
Copy link
Collaborator

shanshin commented Jan 11, 2022

What logs will there be if you run the build without using previously started daemons?
eg /gradlew check --debug --no-daemon

@lenguyenthanh
Copy link
Author

I have the same result with ./gradlew check --debug --no-daemon
Maybe I need to clarify my dependencies: I'm using gradle wrapper 7.3.3 and Kotlin 1.6.10.
And my maven repositories:

repositories {
  mavenCentral()
  maven { url = uri("https://jitpack.io") }
  maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots")}
}

@shanshin
Copy link
Collaborator

Can you provide a small reproducer project?

@lenguyenthanh
Copy link
Author

yes, I can. I will create sometime today or tomorrow.

@lenguyenthanh
Copy link
Author

I don't have time today, so I'll create a sample project over the weekend or next week!

@lenguyenthanh
Copy link
Author

Hey, I have a sample here: lenguyenthanh/sparrow#4.

@shanshin
Copy link
Collaborator

Thanks for the reproducer!
Try to apply the plugin in the root project, instead of the app, this should solve the problems.

@lenguyenthanh
Copy link
Author

oh, thanks for the tip. Is this something kover will fixed or is it caused by something else?
If the latter should we add something to Readme? I can create a PR.

@shanshin
Copy link
Collaborator

We will fix this in the plugin code in the next release.

shanshin added a commit that referenced this issue Jan 20, 2022
Checking parent projects causes a deadlock when projects are deeply nested.
Fixes #116
shanshin added a commit that referenced this issue Jan 21, 2022
Checking parent projects causes a deadlock when projects are deeply nested.
Fixes #116
@shanshin
Copy link
Collaborator

shanshin commented Feb 1, 2022

Fixed in 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants