Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7.0-Beta runs tests in assemble task #353

Closed
ccjernigan opened this issue Apr 24, 2023 · 2 comments · Fixed by #354
Closed

0.7.0-Beta runs tests in assemble task #353

ccjernigan opened this issue Apr 24, 2023 · 2 comments · Fixed by #354
Assignees
@shanshin
Labels
Bug Bug issue type S: ready for release Status: merged in the main branch

Comments

@ccjernigan
Copy link

Describe the bug
When updating from 0.7.0-Alpha to 0.7.0-Beta, I noticed that the assemble task is running my tests.

Expected behavior
Tests shouldn't run unless I invoke the "check" task

Reproducer
I have a branch on this project which reproduces the issue: https://github.com/zcash/secant-android-wallet/tree/kover-0.7.0-Beta

I made one test case intentionally fail, which makes the problem more obvious. Kover is configured under build-conventions-secant, then applied to the individual modules.

  1. Check out the repo with the kover-0.7.0-Beta branch
  2. Run ./gradlew assemble

Reports

 ./gradlew assemble

> Task :preference-api-lib:jvmTest FAILED

co.electriccoin.zcash.preference.model.entry.BooleanPreferenceDefaultTest[jvm] > value_default_true[jvm] FAILED
    java.lang.AssertionError at BooleanPreferenceDefaultTest.kt:19

Environment

  • Kover Gradle Plugin version: 0.7.0-Beta
  • Gradle version: 7.6
  • Kotlin project type: Kotlin/Multiplatform. (The project linked above is an Android project, but it reproduces in a multiplatform module without any Android integration)
@ccjernigan ccjernigan added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Apr 24, 2023
@shanshin
Copy link
Collaborator

Hi, thanks for the report!
Indeed, Kover artifacts should not be generated when running the assemble task.

shanshin added a commit that referenced this issue Apr 24, 2023
@shanshin
Disabled artifact generation when calling the assemble task
d1611df 
Fixes #353

When starting an `assemble` task, all project artifacts marked as visible are generated.
Kover artifacts are marked as invisible so that they are created only when generating reports.
Also, Android projects have several different artifacts that should not be generated all at once
@shanshin shanshin mentioned this issue Apr 24, 2023
Merged
@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: untriaged Status: issue reported but unprocessed labels Apr 24, 2023
shanshin added a commit that referenced this issue May 2, 2023
@shanshin
Disabled artifact generation when calling the assemble task (#354)
427357f 
Fixes #353

When starting an `assemble` task, all project artifacts marked as visible are generated.
Kover artifacts are marked as invisible so that they are created only when generating reports.
Also, Android projects have several different artifacts that should not be generated all at once
@shanshin shanshin reopened this May 2, 2023
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: in progress Status: implementing or design in process labels May 2, 2023
@HonzaR HonzaR mentioned this issue May 8, 2023
Merged
13 tasks
@shanshin
Copy link
Collaborator

Fixed in 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled artifact generation when calling the assemble task Kotlin/kotlinx-kover
2 participants
@ccjernigan @shanshin