Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report variant level filters are ignored #366

Closed
shanshin opened this issue May 9, 2023 · 1 comment · Fixed by #367
Closed

Report variant level filters are ignored #366

shanshin opened this issue May 9, 2023 · 1 comment · Fixed by #367
Assignees
@shanshin
Labels
Bug Bug issue type S: ready for release Status: merged in the main branch

Comments

@shanshin
Copy link
Collaborator

shanshin commented May 9, 2023

Describe the bug
Filters specified on variant level are ignored.

This configuration has no effect

koverReports {
    defaults {
        filters {
            excludes {
                // exclusion is ignored
                classes("*")
            }
        }
    }
}

Affected version: 0.7.0-Beta
@shanshin shanshin added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels May 9, 2023
@shanshin shanshin self-assigned this May 9, 2023
@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: untriaged Status: issue reported but unprocessed labels May 9, 2023
shanshin added a commit that referenced this issue May 9, 2023
@shanshin
Fixed variant level filters for reports
c18ccd7 
Fixed #366

The report mistakenly took into account only filters inside the report and common filters for all variants, in fact, the overriding order should be: common filters for all variants > filters per variant > filters for a specific report in the variant
shanshin added a commit that referenced this issue May 9, 2023
@shanshin
Fixed variant level filters for reports
18bc558 
Fixes #366

The report mistakenly took into account only filters inside the report and common filters for all variants, in fact, the overriding order should be: common filters for all variants > filters per variant > filters for a specific report in the variant
@shanshin shanshin mentioned this issue May 9, 2023
Merged
shanshin added a commit that referenced this issue May 10, 2023
@shanshin
Fixed variant level filters for reports
24a9c92 
Fixes #366

The report mistakenly took into account only filters inside the report and common filters for all variants, in fact, the overriding order should be: common filters for all variants > filters per variant > filters for a specific report in the variant

PR: #367
@shanshin shanshin reopened this May 10, 2023
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: in progress Status: implementing or design in process labels May 10, 2023
@shanshin
Copy link
Collaborator Author

Fixed in 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed variant level filters for reports Kotlin/kotlinx-kover
1 participant
@shanshin