Add compiler plugin dependency only for projects with KGP >= 1.6.20 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
May 16, 2022
| val (majorVersion, minorVersion, patch) = if (versions.size > 2) { | ||
| versions.take(3).map { it.toInt() } | ||
| } else { | ||
| versions.take(2).map { it.toInt() }.plus(0) |
There was a problem hiding this comment.
Is it a real case? 1.6.0 may return "1.6" from getKotlinPluginVersion?
There was a problem hiding this comment.
Theoretically, it can return anything written to the project.properties file, but in practice only full kotlin versions 1.x.y are written there. So, I think, we can drop this check
There was a problem hiding this comment.
Please do, otherwise it's dead code that will be puzzling us in the future
|
Otherwise good to go |
qwwdfsad
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225