Prepare atomicfu build scripts for inclusion into the main aggregate as a user project #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasjas
force-pushed
the
as/KTI-1016-atomicfu-to-aggregate
branch
from
9849795
to
b1225b8
Compare
qwwdfsad
requested changes
Nov 28, 2022
There was a problem hiding this comment.
- Please change the target branch to
develop - Currently, all RR/train support is stretched through all Gradle files. It's both hard to maintain and understand. Please create a separate
.ktsfile and declare all RR-specific variables and functions there. Then on call-sites we will have clear entry-point:
// KotlinDevSupport.kts
// Here will be a huge comment explaining why this is needed and how it is used
val kotlinDevRepo = ...
fun getApiVersionForOverriddenKotlin() = ...
Pros: everything is documented in a single place, easy to maintain, hard to miss, no questions on individual call sites
stasjas
force-pushed
the
as/KTI-1016-atomicfu-to-aggregate
branch
4 times, most recently
from
dabdd28
to
dcf89d6
Compare
stasjas
force-pushed
the
as/KTI-1016-atomicfu-to-aggregate
branch
from
dcf89d6
to
9c93c31
Compare
|
LGTM 👍 |
stasjas
force-pushed
the
as/KTI-1016-atomicfu-to-aggregate
branch
2 times, most recently
from
006a510
to
f8bd635
Compare
…build //KTI-1016 Parametrize kotlin api version, kotlin language version. Support passing an url for a kotlin compiler repository, drop space kotlin/dev repo from dependencies: Kotlin compiler artifacts should be downloaded from maven central by default. In case of compiling with not-published into the MC kotlin compiler artifacts, a kotlin_repo_url should be specified as a gradle parameter(E.g. space kotlin/dev repo).
stasjas
force-pushed
the
as/KTI-1016-atomicfu-to-aggregate
branch
from
f79e5d5
to
ae7433b
Compare
qwwdfsad
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.