Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default value of DebugProbes.enableCreationStackTraces to false #3783

Closed
qwwdfsad opened this issue Jun 19, 2023 · 0 comments
Closed

Comments

@qwwdfsad
Copy link
Member

DebugProbes.enableCreationStackTraces is the property of the debugger, indicating that the stacktrace of the coroutine creation site has to be captured.

This is a performance-sensitive operation (e.g. fillInStackTrace is typically the heaviest operation in the coroutines lifecycle), incurring significant (double digit) overhead on production systems with little to no benefits. On the other side, the creation stacktrace itself is not asynchronous -- it doesn't attempt to recover the call site stacktrace, meaning that coroutines launched from a suspend function are unlikely to have a meaningful creation stacktrace.

Most of the known probes API consumers disable it; moreover, even our documentation recommends doing so.

My suggestion is to switch it off by default and leave as a legacy and/or advanced option

qwwdfsad added a commit that referenced this issue Jan 30, 2024
* Adjust tests and the documentation
* Rationale: this option implies significant and non-trivial overhead yet its utility is unclear (e.g. we got a multitude of signals that this option brings no use and none that it's useful even when asked explicitly)

Fixes #3783
qwwdfsad added a commit that referenced this issue Feb 14, 2024
* Adjust tests and the documentation
* Rationale: this option implies significant and non-trivial overhead yet its utility is unclear (e.g. we got a multitude of signals that this option brings no use and none that it's useful even when asked explicitly)

Fixes #3783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant