Throw SerializationException instead of IllegalStateException in Enum… #1325
+53
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a bug in our JS codegen, @sandwwraith could you please take a look? |
|
I'll see, but it looks like the problem is not codegen — both IR and legacy test fail |
Because of shift+=7 addition and strict condition shift != 64, the loop never ends. This resulted in test timeout fail on JS. On JVM and Native, due to shift overflow, the test eventually came out of loop (but that took quite a big amount of time, about million overflows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Serializer
Fixes #1303