Introduce kotlinx-serialization-bom #1356
Merged
+58
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
reviewed
Mar 3, 2021
| // (e.g. on linux it will include only linuxx64 artifacts and no macosx64) | ||
| // It shouldn't be a problem as usually consumers need to use generic *-native artifact | ||
| // Gradle will choose correct variant by using metadata attributes | ||
| if (it.artifacts.any { it.extension == 'klib' }) return |
There was a problem hiding this comment.
Wouldn't it cause problems for js ir?
There was a problem hiding this comment.
BOM is meaningful only for the JVM platform right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220