Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @JsonNames for enum values #1473

Merged
merged 3 commits into from
May 13, 2021
Merged

Support @JsonNames for enum values #1473

merged 3 commits into from
May 13, 2021

Conversation

sandwwraith
Copy link
Member

Fixes #1458

@sandwwraith sandwwraith requested a review from qwwdfsad May 11, 2021 19:45
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo two small comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sandwwraith sandwwraith requested a review from qwwdfsad May 12, 2021 14:24
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@sandwwraith sandwwraith merged commit c0976fd into dev May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants