Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark block of encodeStructure, decodeStructure and encodeCollection as crossinline #1750

Closed
qwwdfsad opened this issue Nov 1, 2021 · 1 comment
Closed

Mark block of encodeStructure, decodeStructure and encodeCollection as crossinline #1750

qwwdfsad opened this issue Nov 1, 2021 · 1 comment
Assignees
@qwwdfsad
Labels
feature

Comments

@qwwdfsad
Copy link
Member

qwwdfsad commented Nov 1, 2021

And reduce the bytecode size of inlined try-catch-finally block that is totally redundant.

It may be a source incompatible change, so it can only be done in the scope of the next major release
@ansman
Copy link
Contributor

ansman commented Nov 16, 2021 •
edited

Partially fixed in #1749 (encodeCollection is fixed)

@qwwdfsad qwwdfsad self-assigned this Apr 27, 2022
qwwdfsad added a commit that referenced this issue Apr 27, 2022
@qwwdfsad
Mark block in corresponding encodeStructure/decodeStructure extension…
a1de515 
…s as crossinline to reduce amount of bytecode

Fixes #1750
@qwwdfsad qwwdfsad mentioned this issue Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ansman @qwwdfsad