Support serialization of collections that are not lists #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
collection-serializer
branch
from
584045c
to
bb65e84
Compare
sschuberth
force-pushed
the
collection-serializer
branch
from
4d65726
to
43fc8b2
Compare
So far there was an implicit assumption hard-coded that collections are always lists. However, sets are also collections, and can be serialized to JSON arrays just like lists. This change allows to serialize generic collections independently of the concrete implementation. Fixes Kotlin#1421.
Now with `CollectionSerializer` inheriting from `ListLikeSerializer`, it makes sense to rename `ListLikeSerializer` to the more generic `CollectionLikeSerializer`.
sschuberth
force-pushed
the
collection-serializer
branch
from
43fc8b2
to
ed99652
Compare
|
Reviews anyone? @sandwwraith maybe? |
|
@sschuberth Sorry, I was on vacation. I'll return to your PR in a couple of days. |
pdvrieze
reviewed
Jan 17, 2022
core/commonMain/src/kotlinx/serialization/internal/CollectionSerializers.kt
Show resolved
Hide resolved
|
Please also execute |
Done by running `./gradlew apiDump`.
I've added a new commit that updates the API dump for all introduced changes at once, I hope that's fine. Let me know if you want API dump changes squashed into the commit that do the actual changes instead. |
|
Oops. I've just realized that this PR is opened against |
sandwwraith
pushed a commit
that referenced
this pull request
Jan 28, 2022
So far there was an implicit assumption hard-coded that collections are always lists. However, sets are also collections, and can be serialized to JSON arrays just like lists. This change allows serializing generic collections independently of the concrete implementation. Fixes #1421. * CollectionSerializers: Remove redundant visibility modifiers * SealedGenericClassesTest: Remove unused variables to avoid warnings * Rename `ListLikeSerializer` to `CollectionLikeSerializer` Now with `CollectionSerializer` inheriting from `ListLikeSerializer`, it makes sense to rename `ListLikeSerializer` to the more generic `CollectionLikeSerializer`. (cherry picked from commit d254e6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far there was an implicit assumption hard-coded that collections are
always lists. However, sets are also collections, and can be serialized
to JSON arrays just like lists.
This change allows to serialize generic collections independently of the
concrete implementation.
Fixes #1421.