Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark block in corresponding encodeStructure/decodeStructure extension… #1917

Merged
merged 1 commit into from Apr 27, 2022

Conversation

qwwdfsad
Copy link
Member

…s as crossinline to reduce amount of bytecode

Fixes #1750

…s as crossinline to reduce amount of bytecode

Fixes #1750
@sandwwraith
Copy link
Member

Such a change would prohibit early returns from these lambdas, thus this change is non source-compatible. Are we OK with that?

@qwwdfsad
Copy link
Member Author

Yep, the ticket explicitly mentions that.
The incompatibility requires to add a FQN to return, you can see an example in AbstractPolymorphicSerializer.kt

@qwwdfsad qwwdfsad merged commit 05f0dfd into dev Apr 27, 2022
@qwwdfsad qwwdfsad deleted the fix-decode-structure branch April 27, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants