Fix MissingFieldException duplication #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
commented
Feb 28, 2023
| @@ -87,6 +87,9 @@ internal open class StreamingJsonDecoder( | |||
| return result | |||
|
|
|||
| } catch (e: MissingFieldException) { | |||
| // Add "at path" if and only if we've just caught an exception and it hasn't been augmented yet | |||
| if (e.message!!.contains("at path")) throw e | |||
| // NB: we could've use some additional flag marker or augment the stacktrace, but it seemed to be as too much of a burden | |||
| throw MissingFieldException(e.missingFields, e.message + " at path: " + lexer.path.getPath(), e) | |||
There was a problem hiding this comment.
I would prefer val mfe = .. new mfe with better message ... to later do mfe.stackTrace = e.stackTrace, but unfortunately, it works only on JVM, not sure if we should bother
shanshin
reviewed
Feb 28, 2023
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Show resolved
Hide resolved
formats/json-tests/jvmTest/src/kotlinx/serialization/json/MissingFieldExceptionWithPathTest.kt
Outdated
Show resolved
Hide resolved
formats/json-tests/jvmTest/src/kotlinx/serialization/json/MissingFieldExceptionWithPathTest.kt
Outdated
Show resolved
Hide resolved
shanshin
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2212