Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test & fix several exception messages from Json parser #2406

Merged
merged 2 commits into from Aug 11, 2023

Conversation

sandwwraith
Copy link
Member

To avoid cryptic and incorrect ones, such as Expected quotation mark '"', but had '"' instead or unexpected token: 10.

Fixes #2360
Fixes #2399

Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I played with failure modes for a while, and it is much more approachable 👍

To avoid cryptic and incorrect ones, such as `Expected quotation mark '"', but had '"' instead` or `unexpected token: 10`.

Fixes #2360
Fixes #2399

Also remove @PublishedApi from BATCH_SIZE to remove it from public API dump.
…ss anymore, it was split to ReaderJsonLexer and StringJsonLexer.
@sandwwraith sandwwraith merged commit 1e88d42 into dev Aug 11, 2023
3 checks passed
@sandwwraith sandwwraith deleted the fix-error-messages branch August 11, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants