Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the modal view videos too? #205

Open
ch-ivy opened this issue Apr 17, 2020 · 4 comments
Open

Does the modal view videos too? #205

ch-ivy opened this issue Apr 17, 2020 · 4 comments
Labels

Comments

@ch-ivy
Copy link

ch-ivy commented Apr 17, 2020

I want to know if the modal gallery can view videos

@Ks89
Copy link
Owner

Ks89 commented Apr 17, 2020

Hi @ch-ivy not at the moment.
However if you want to contribute I'll really happy to help you.

As a sort of step by step procedure, I propose something like this to everyone interested to contribute:

  1. Try to understand all possible ways to include videos in a html page (with different formats) in smaller demo projects
  2. Consider also YouTube and other sources
  3. Base on these info, we should decide which scenarios we want to cover, for instance which formats, or should we support also videos from other sources like YouTube?
  4. Define apis (probably simple)
  5. Based on 800 branch of this repo, start to implement everything
  6. Test new stuff

@Ks89 Ks89 added the question label Apr 17, 2020
@Ks89
Copy link
Owner

Ks89 commented Apr 17, 2020

This could be a very cool feature for a new major release (let say 9.0.0) and it could be done by any contributor, because it's a very specific feature, not like what I'm doing with 8.0.0.

@Ks89 Ks89 pinned this issue Apr 17, 2020
@ch-ivy
Copy link
Author

ch-ivy commented Nov 24, 2020

I've not really contributed to an open source project before, where can i see a walkthrough in navigating the project to know exactly where i can implement my changes

@Ks89
Copy link
Owner

Ks89 commented Nov 27, 2020

Hi, what do you mean for "walkthrough"?

@Ks89 Ks89 unpinned this issue Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants