Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading spinners for carrousel mode #223

Open
KrlLevchenko opened this issue May 28, 2021 · 1 comment
Open

Loading spinners for carrousel mode #223

KrlLevchenko opened this issue May 28, 2021 · 1 comment

Comments

@KrlLevchenko
Copy link

KrlLevchenko commented May 28, 2021

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

There is no way to use spinner (loading indicator) when using carrousel. If I use modal gallery I see spinner and that is ok but there is no any spinners for carrousel mode
I need this because I have multiple galleries and I'm switching between them.

// Gallery is my own class from backend containing links to photos
public select(gallery: Gallery){
    this.selectedImages = gallery.images.map((p, i) =>
      new Image(i, {
          img: p.url,
          extUrl: p.url,
          description: ''
        },
        {
          img: p.previewUrl
        }
      )
    );
  }

And I see old photos some time after selecting new gallery

Expected behavior

I see spinner while all images not loaded

Environment (the most important section to fill very carefully)


- @ks89/angular-modal-gallery version: 7.2.7
- Node version: 12.16.1
- npm version: 6.13.4




Browser:
- [x] Chrome (desktop) version 90.0.40
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

@Ks89
Copy link
Owner

Ks89 commented May 31, 2021

Hi!
Loading spinners in Carousel is still not implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants