Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component serialization doesn't match vanilla #788

Closed
Kebab11noel opened this issue Jun 17, 2022 · 0 comments · Fixed by #789
Closed

Component serialization doesn't match vanilla #788

Kebab11noel opened this issue Jun 17, 2022 · 0 comments · Fixed by #789

Comments

@Kebab11noel
Copy link

Some components when serialized doesn't match vanilla's string represantation which causes issues with server side signature validation. Example of a difference:
Adventure:

{"extra":[{"color":"#ff00ff","text":"PREPEND\u003e"},{"text":"/sign test"},{"color":"#ff00ff","text":"\u003cAPPEND"}],"text":""}

Minecraft:

{"extra":[{"color":"#FF00FF","text":"PREPEND>"},{"text":"/sign test"},{"color":"#FF00FF","text":"<APPEND"}],"text":""}
zml2008 added a commit that referenced this issue Jun 20, 2022
bug(#788): disable html escaping and use uppercase hex colour codes
@zml2008 zml2008 added this to the 4.12.0 milestone Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants