Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction tests #1649

Open
MrBurmark opened this issue May 16, 2024 · 2 comments
Open

Reduction tests #1649

MrBurmark opened this issue May 16, 2024 · 2 comments
Labels

Comments

@MrBurmark
Copy link
Member

MrBurmark commented May 16, 2024

While looking through the reducer code and tests I came across some things potential issues.

  • Reducers have an initial value that defaults to T(). Does this make sense for reducers where the identity of the operator does not equal T(). For example doing a min reduce with integers over a set of positive numbers with a default constructed reducer would always result in 0 which is probably not desired and the cause may not be immediately obvious.
  • The reducer unit tests don't generate their test files via cmake.
  • The reducer unit tests don't test bitwise and/or reducers.
  • Some of the reducer unit tests for construction are disabled for gpu policies, don't we want to ensure a consistent interface?
  • Some of the reducer unit tests do different things for gpu policies, don't we want to ensure a consistent interface?
  • Some of the reducer unit tests use the reductions in forone which is not a supported context, it doesn't go through the same mechanisms that forall does like make_launch_body and it doesn't make a per thread copy of the lambda.
@artv3
Copy link
Member

artv3 commented May 16, 2024

Which reducer unit test are disabled for gpu policies?

@MrBurmark
Copy link
Member Author

MrBurmark commented May 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants