Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing case in blt_patch_target and blt_determine_scope #658

Open
white238 opened this issue Oct 4, 2023 · 0 comments
Open

Missing case in blt_patch_target and blt_determine_scope #658

white238 opened this issue Oct 4, 2023 · 0 comments

Comments

@white238
Copy link
Member

white238 commented Oct 4, 2023

We are missing a case where we need to downscope from PUBLIC to INTERFACE in a couple places.

Truncated output from user:

-- [foo property] 'foo' is a CMake target
-- [foo property] IMPORTED: TRUE
-- [foo property] NAME: foo
-- [foo property] TYPE: STATIC_LIBRARY

Error:

CMake Error at /blt/cmake/BLTMacros.cmake:467 (target_link_libraries):
  IMPORTED library can only be used with the INTERFACE keyword of
  target_link_libraries
Call Stack (most recent call first):
  cmake/thirdparty/SetupAxomThirdParty.cmake:214 (blt_patch_target)
  cmake/CMakeBasics.cmake:20 (include)
  CMakeLists.txt:126 (include)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant