Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to set path to imagenet data #2192

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Added option to set path to imagenet data #2192

wants to merge 11 commits into from

Conversation

graham63
Copy link
Contributor

@graham63 graham63 commented Feb 13, 2023 •
edited by benson31

Closes #2184.

benson31
benson31 reviewed Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test, but looks good.

applications/vision/data/imagenet/__init__.py Outdated Show resolved Hide resolved
applications/vision/resnet.py Outdated Show resolved Hide resolved
applications/vision/data/imagenet/__init__.py Outdated Show resolved Hide resolved
@graham63 graham63 marked this pull request as ready for review February 14, 2023 22:26
graham63 and others added 11 commits March 6, 2023 10:07
@graham63
Added option to set path to imagenet data
247787f
@graham63 @benson31
Update applications/vision/resnet.py
21c7b7b 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/data/imagenet/__init__.py
9003d9c 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/data/imagenet/__init__.py
5f2e6ef 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/resnet.py
767594d 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/data/imagenet/__init__.py
95c6e79 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/data/imagenet/__init__.py
a67af75 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63 @benson31
Update applications/vision/data/imagenet/__init__.py
8d3a812 
Co-authored-by: Tom Benson <30674819+benson31@users.noreply.github.com>
@graham63
Removed resolved FIXME note
9bf2931
@graham63
Added note about --data-path in .rst docs
7392542
@graham63
Added --data-path to densenet and alexnet
5fbe41e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benson31 benson31 benson31 left review comments

@bvanessen bvanessen Awaiting requested review from bvanessen

At least 1 approving review is required to merge this pull request.

Assignees

@graham63 graham63

Labels
application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data paths should be tied to CLI for Resnet app
2 participants
@graham63 @benson31