Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-place layer followed by a viewing layer crashes on backprop #2274

Open
tbennun opened this issue Jun 12, 2023 · 0 comments
Open

In-place layer followed by a viewing layer crashes on backprop #2274

tbennun opened this issue Jun 12, 2023 · 0 comments
Assignees

Comments

@tbennun
Copy link
Contributor

tbennun commented Jun 12, 2023

If a layer is set to be in-place, and it is followed by a viewing layer (identity, reshape, etc.), and keep error signals is off, a crash happens in the deep-copy of the tensors during backprop. For now, we will have a very specific check that disables the in-placeness in this case, but we should remove that after the update.

@ndryden @benson31 Pinging you to fix this after new tensors are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants