Spack development branch build issue

[jvwilliams23]

Hi,
I used the following command to build lbann with spack: lbann@develop^dihydrogen@0.2.1^hydrogen@develop. This gave the following error:

     436    /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/lib/spack/env/gcc/g++ -DH5_BUILT_AS_DYNAMIC_LIB -DPROTOBUF_USE_DLLS -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE64_SOU
            RCE -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200809L -Dlbann_EXPORTS -I/tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4sg5/spack-build-h7cwgrp -I/tm
            p/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4sg5/spack-src/include -isystem /tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3
            flznj6ve2sx6nh4sg5/spack-build-h7cwgrp/src/proto -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/protobuf-3.21.12-a
            okl4owhq2qmp2avgamt4p772lqgrtnr/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/hwloc-1.11.13-5uir2lihzoho7
            qog4etn5ssthdb6inzp/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/dihydrogen-0.2.1-7ateuqlvj6wqkcrbc3tcyj
            5sybebjvcs/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/hydrogen-develop-lp6gfcrejxsosjsbaxnubn3zelellh2
            a/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/hydrogen-develop-lp6gfcrejxsosjsbaxnubn3zelellh2a/include
            /El -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/openmpi-3.1.6-kfticxef76arioojxvzbltr4gdkl6dov/include -isystem
             /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/conduit-0.8.7-okkjmvzgkcyqwgmzzdu7hkh5ulh437an/include -isystem /lustre/sca
            fellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/conduit-0.8.7-okkjmvzgkcyqwgmzzdu7hkh5ulh437an/include/conduit -isystem /lustre/scafell
            pike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/hdf5-1.8.22-mf7rks26gyh64zsxgkdl3mu5cspc7eiz/include -isystem /lustre/scafellpike/local/HT0
            4543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/parmetis-4.0.3-xvmpbuftyuf7mphpz7hmbhsvuahxkc2d/include -isystem /lustre/scafellpike/local/HT04543/jxc06/
            jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/metis-5.1.0-64hfbbgs57sf24xnw2imeubkvtfhfxmy/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/sp
            ack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/clara-1.1.5-s5hjxwz5x4xmh5sylqbpt6lqcdokwyjj/include -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/miniconda3/inclu
            de/python3.10 -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/cereal-1.3.0-m4erqz6fjgmov5w5pq34vg64pdcjpawv/include
             -isystem /lustre/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/zstr-1.0.7-o7gubqow3m4jx6lj3bhbz2lztubcsujh/include -isystem /lust
            re/scafellpike/local/HT04543/jxc06/jxw92-jxc06/spack/opt/spack/linux-rhel7-skylake_avx512/gcc-9.3.0/zlib-1.2.13-pv3fue4yfrg2wwftonn6mhox6oworevh/include -DLBANN_SET_EL_RNG -std=c++1
            7 -g -Wall -Wextra -Wno-unused-parameter -Wnon-virtual-dtor -Wshadow -Wno-deprecated-declarations -O3 -DNDEBUG -std=gnu++17 -fPIC -fopenmp -pthread -DCONDUIT_RELAY_IO_MPI_ENABLED -D
            CONDUIT_BLUEPRINT_MPI_ENABLED -MD -MT CMakeFiles/lbann.dir/src/objective_functions/weight_regularization/l2.cpp.o -MF CMakeFiles/lbann.dir/src/objective_functions/weight_regularizat
            ion/l2.cpp.o.d -o CMakeFiles/lbann.dir/src/objective_functions/weight_regularization/l2.cpp.o -c /tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4
            sg5/spack-src/src/objective_functions/weight_regularization/l2.cpp
     437    In file included from /tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4sg5/spack-src/include/lbann/objective_functions/weight_regularization/l2.hp
            p:30,
     438                     from /tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4sg5/spack-src/src/objective_functions/weight_regularization/l2.cpp:27:
  >> 439    /tmp/jxw92-jxc06/spack-stage/spack-stage-lbann-develop-h7cwgrpnpn5sy3flznj6ve2sx6nh4sg5/spack-src/include/lbann/comm_nb_request.hpp:80:3: error: 'MPI_Request' does not name a type;
            did you mean 'MPIO_Request'?
     440       80 |   MPI_Request raw_mpi_req = MPI_REQUEST_NULL;
     441          |   ^~~~~~~~~~~
     442          |   MPIO_Request

When building with cmake, the same thing happened and I resolved it by just including #include <mpi.h> in src/include/lbann/comm_nb_request.hpp. But I had some other issues when building with cmake so I decided to change to spack.

[benson31]

Hi @jvwilliams23. Thanks for bringing this to our attention. It looks like you're building without Aluminum support. Aluminum is recommended for nearly every situation nowadays, and, indeed, it will become a requirement soon. In the meantime, this should work, so I'll put up a patch. To get you going sooner, you might try ^hydrogen@develop+al.