Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take a long hard look at the benchmarks and make some of them JMH #335

Open
Palmr opened this issue Nov 27, 2020 · 1 comment
Open

Take a long hard look at the benchmarks and make some of them JMH #335

Palmr opened this issue Nov 27, 2020 · 1 comment
Projects

Comments

@Palmr
Copy link
Member

Palmr commented Nov 27, 2020

There are many classes and tests under the "perf" sourceset.
Not sure what all of these do, if they're relevant etc.

There is currently no way to track performance of the Disruptor in CI. Using some standard tools like JMH we can write benchmarks which output results in a standard way for tracking & display.

We also have a lot of performance related code in the code base which doesn't appear to have any directly linked benchmarks proving it's a faster way of doing things.
Performance code is typically harder to read and needs to justify its existence with some form of benchmark.

@Palmr Palmr created this issue from a note in 4.0 (In progress) Nov 27, 2020
@Palmr
Copy link
Member Author

Palmr commented Nov 27, 2020

Since #314 we now have JMH benchmarks in the code.
Need to add more and consider where we can find a stable environment to run them and record results.

@Palmr Palmr changed the title Take a long hard look at the benchmarks and make them JMH Take a long hard look at the benchmarks and make some of them JMH Nov 27, 2020
@Palmr Palmr moved this from In progress to To do in 4.0 Feb 18, 2021
@Palmr Palmr moved this from To do to Not blockers to 4.0 in 4.0 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0
Not blockers to 4.0
Development

No branches or pull requests

1 participant