-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert node- and product-related lists to sets #148
Comments
Also node |
This will be more involved than I first thought. We can't take sets of
See https://eng.lyft.com/hashing-and-equality-in-python-2ea8c738fb9d for a nice summary of the trouble with using custom objects in sets. (The approach I'm considering above doesn't convert them to immutables, though, it just uses indices instead of objects in the sets.) |
This is not really a good idea. Lists are faster to iterate over than sets. Sets are faster to check membership but that's not the primary use case. |
e.g.,
raw_materials_by_product()
etc should return sets, for speedThe text was updated successfully, but these errors were encountered: