aa async resolver #1074
Draft
aa async resolver #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naugtur
commented
Mar 14, 2024
packages/aa/test/benchmark1.spec.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| const { realpathSync, lstatSync } = require('node:fs') | |||
There was a problem hiding this comment.
This was moved/changed in a different PR. I need to rebase and clean up.
naugtur
commented
Mar 14, 2024
| * @param {(item: T) => Promise<any>} mapper | ||
| * @returns {Promise<void>} | ||
| */ | ||
| async function runParallelMax(parallelMax, items, mapper) { |
There was a problem hiding this comment.
note: this function could be much more sophisticated so that it tracks which async jobs finished and starts new ones as they do. The jobs are similar enough to each other tho, that it might not bring a lot of improvement to the execution time.
There was a problem hiding this comment.
update - quick test of the concept:
async function runParallelMax(parallelMax, items, mapper) {
items = items.reverse()
return new Promise((resolve, reject) => {
let promises = 0
const boop = () => {
if (items.length === 0) {
if(promises === 0) resolve()
return
}
const p = mapper(items.pop())
promises++
p.then(()=>{
promises--
boop()
}, reject)
}
for (let i = 0; i < parallelMax; i++) {
boop()
}
})
}with this implementation it's a few percent slower, so there's not much to gain from smarter parallelization
BREAKING CHANGE: change in `resolver` option type
naugtur
force-pushed
the
naugtur/aa-async-resolver
branch
from
60d2c57
to
448fbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
Introduces a major change in the programmatic API but to a parameter that was seldom used. Will require a major bump but no consequences in adoption or such.
Performance is almost unaffected.