Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserify: getting super tired of updating test/fixtures/secureBundling/lavamoat/node/policy.json #1103

Closed
3 tasks
boneskull opened this issue Mar 13, 2024 · 1 comment · Fixed by #1104
Closed
3 tasks
Assignees
Labels
chore overhead, tests, dev env, etc. pkg:lavamoat-browserify Changes in package lavamoat-browserify

Comments

@boneskull
Copy link
Contributor

This file changes almost every time package-lock.json changes. It fails the dirty check often. As @naugtur put it, it's a "commit detector."

  1. We need to remove it from VCS.
  2. If this policy file is used as a snapshot: It should not be used as a snapshot. We can make assertions about some subset of the policy, if necessary.
  3. If this policy file is used only in the context of execution, then great--we don't need to do anything else except remove it from VCS.

I'll look at how exactly it's being consumed, then do 1 and (2 or 3).

@boneskull boneskull added chore overhead, tests, dev env, etc. pkg:lavamoat-browserify Changes in package lavamoat-browserify labels Mar 13, 2024
@boneskull boneskull self-assigned this Mar 13, 2024
@boneskull
Copy link
Contributor Author

Ref: #987

boneskull added a commit that referenced this issue Mar 13, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
legobeat pushed a commit that referenced this issue Mar 14, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 19, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 19, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 20, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 21, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
naugtur pushed a commit that referenced this issue Mar 25, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 26, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
boneskull added a commit that referenced this issue Mar 26, 2024
This also avoids a second unnecessary run of the `test:prep` script when `npm test` is invoked from the workspace root.

Closes #1103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore overhead, tests, dev env, etc. pkg:lavamoat-browserify Changes in package lavamoat-browserify
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant