Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aa: flaky symlink test #1134

Open
boneskull opened this issue Mar 27, 2024 · 0 comments
Open

aa: flaky symlink test #1134

boneskull opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working chore overhead, tests, dev env, etc.

Comments

@boneskull
Copy link
Contributor

Here's an excerpt from a failing build:

> @lavamoat/aa@4.2.0 test:run
> ava


  ✘ [fail]: symlink-perf › [bench] isSymlink is significantly faster than realpathSync in a naive microbenchmark Rejected promise returned by test
  ✔ index › project 1
  ✔ index › project 2
  ✔ index › project 3
  ✔ index › project 1 - with custom resolver
  ✔ index › project 1 - resolution missing silently
  ✔ index › project 1 - resolution failure
  ✔ index › project 4 - workspace symlink
  ─

  symlink-perf › [bench] isSymlink is significantly faster than realpathSync in a naive microbenchmark

  Rejected promise returned by test. Reason:

  Error {
    code: 'EEXIST',
    dest: '/home/runner/work/LavaMoat/LavaMoat/packages/aa/test/projects/4/node_modules/aaa',
    errno: -17,
    path: '/home/runner/work/LavaMoat/LavaMoat/packages/aa/test/projects/4/packages/aaa',
    syscall: 'symlink',
    message: 'EEXIST: file already exists, symlink \'/home/runner/work/LavaMoat/LavaMoat/packages/aa/test/projects/4/packages/aaa\' -> \'/home/runner/work/LavaMoat/LavaMoat/packages/aa/test/projects/4/node_modules/aaa\'',
  }

  ─

  1 test failed
npm ERR! Lifecycle script `test:run` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @lavamoat/aa@4.2.0 
npm ERR!   at location: /home/runner/work/LavaMoat/LavaMoat/packages/aa 
npm ERR! Lifecycle script `test` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @lavamoat/aa@4.2.0 
npm ERR!   at location: /home/runner/work/LavaMoat/LavaMoat/packages/aa 

This is likely some sort of race condition; if so, it should be addressable by using test.serial() somewhere.

Note

This flake is not the same flake as noted in #1118.

@boneskull boneskull added bug Something isn't working chore overhead, tests, dev env, etc. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore overhead, tests, dev env, etc.
Projects
None yet
Development

No branches or pull requests

2 participants