Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavamoat-core: modularize test utils #1136

Open
boneskull opened this issue Mar 27, 2024 · 0 comments
Open

lavamoat-core: modularize test utils #1136

boneskull opened this issue Mar 27, 2024 · 0 comments
Labels
chore overhead, tests, dev env, etc. developer experience public APIs, exports, program output, etc

Comments

@boneskull
Copy link
Contributor

Various packages (lavamoat-node, lavamoat-browserify, @lavamoat/endomoat) depend on test utils in lavamoat-core. Most/all of the functionality reused involves execution of scenarios.

This necessitates lavamoat-core shipping (and likely generating types for) these utils. This isn't terrible, but it's also not ideal.

Consider yanking stuff like test/util.js out of lavamoat-core and into its own module, e.g., @lavamoat/test-util. Other reusable test utilities could be moved there as well.

@boneskull boneskull added chore overhead, tests, dev env, etc. developer experience public APIs, exports, program output, etc labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore overhead, tests, dev env, etc. developer experience public APIs, exports, program output, etc
Projects
None yet
Development

No branches or pull requests

1 participant