Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Typescript #53

Closed
14 tasks done
Tracked by #52
Lazerbeak12345 opened this issue Feb 19, 2022 · 0 comments · Fixed by #52
Closed
14 tasks done
Tracked by #52

Move to Typescript #53

Lazerbeak12345 opened this issue Feb 19, 2022 · 0 comments · Fixed by #52
Assignees
Labels
enhancement New feature or request Library Major version number wishlist would require me to up the version number for the library
Milestone

Comments

@Lazerbeak12345
Copy link
Owner

Lazerbeak12345 commented Feb 19, 2022

Is your feature request related to a problem? Please describe.
There's a ton of bugs that would be fixed if strong typing were to be used. This would also decrease the amount of unit tests that will be needed by about 10-20%.

Describe the solution you'd like
In the v5-alpha branch gradually move to typescript. Have a dist folder to hold the output on the master branch, and have the npm include that, the .d.ts file and have the html source that javascript file. In addition, have a pre-bundled version as well with all runtime-deps (as there will be some in the future) bundled and the whole file minified. The html version will likely use that, unless it moves to requirejs.

Describe alternatives you've considered
JsDoc, or whatever it's called doesn't require compiling to run - but I think that while this is nice, it means that I'd be harder to use npm libraries as dependencies.

Additional context
I've used a similar approach for spud-slices - but I can do it better this time.

Steps

@Lazerbeak12345 Lazerbeak12345 added enhancement New feature or request Library Major version number wishlist would require me to up the version number for the library labels Feb 19, 2022
@Lazerbeak12345 Lazerbeak12345 added this to To do in Convert to typescript via automation Feb 19, 2022
@Lazerbeak12345 Lazerbeak12345 added this to the Version 5 milestone Feb 19, 2022
@Lazerbeak12345 Lazerbeak12345 linked a pull request Feb 19, 2022 that will close this issue
Merged
6 tasks
@Lazerbeak12345 Lazerbeak12345 moved this from To do to In progress in Convert to typescript Feb 19, 2022
Lazerbeak12345 added a commit that referenced this issue Mar 2, 2022
Probabbly not the best way to go about this.

Related to #53
@Lazerbeak12345 Lazerbeak12345 self-assigned this Mar 5, 2022
@Lazerbeak12345 Lazerbeak12345 mentioned this issue Mar 30, 2022
Merged
6 tasks
Convert to typescript automation moved this from In progress to Done Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Library Major version number wishlist would require me to up the version number for the library
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant