Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an offical statement if the Leaflet.Draw is not maintained anymore #1041

Open
Falke-Design opened this issue Mar 27, 2022 · 9 comments
Open

Comments

@Falke-Design
Copy link
Member

Falke-Design commented Mar 27, 2022

@jacobtoye I think it is pretty clear that Leaflet.draw is not maintained anymore. It would be nice if you can add an offical statement and add it to the top of the Readme. Maybe archiv this repo as well.

Also you can provide a list of good alternatives like Leaflet-Geoman or the plugin list on Leaflet: https://leafletjs.com/plugins.html#edit-geometries

@indigoxela
Copy link

indigoxela commented Mar 29, 2022

it is pretty clear that Leaflet.draw is not maintained anymore

What a pity! Is there any way to keep it (minimally) supported? (It still works with the current Leaflet 1.8.0 dev version.)

Leaflet-Geoman may be a cool project, but it's not a drop-in replacement and would require to completely rewrite integration code from scratch.

Github lists a usage of 3.5k. That may not be huge, but it's still significant.

@indigoxela
Copy link

indigoxela commented Oct 10, 2022

With a recent commit in Leaflet, this module will break (_flat got removed).
A PR is available for years now, but there's no maintenance, so it never got merged #892

The reason why I chose Leaflet.draw in my integration was that it's prominently linked on this organization's page: https://github.com/Leaflet

But obviously it's neither an officially supported plugin, nor maintained at all. I'm not sure how many other people misunderstood the status of this plugin the way I did, but I see a "used by 4k" in the sidebar of the main page, so it's not just me. And 4k+ seems significant usage to me.

Breaking Leaflet.draw will probably mean that many integrations can't keep up with the main library anymore. At least without a major rewrite - if that's possible at all.

@Falke-Design
Copy link
Member Author

I'm not 100% sure but it looks like, there was a time, where big plugins where moved to the Leaflet Project. But the plugins kept maintained by the origin maintainers.

@indigoxela maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

@indigoxela
Copy link

... maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

If that would be possible... sure! Geoman is a cool project, but appears substantially different to me. Not sure if I could provide much help to get that task done - my js skills are rather limited.

I know, that's out of scope of this issue here - but could breaking changes in Leaflet (core) be postponed to a major release like 2.x? I'm not sure if people expect such a breaker in a minor release, or even worse - in a bug release (like possibly 1.9.3).

@Falke-Design
Copy link
Member Author

... maybe we can find together a way to do a "drop-in replacement" from Leaflet-Draw to Leaflet-Geoman.

If that would be possible... sure! Geoman is a cool project, but appears substantially different to me. Not sure if I could provide much help to get that task done - my js skills are rather limited.

I will take a look into it, but this will take some time.

I know, that's out of scope of this issue here - but could breaking changes in Leaflet (core) be postponed to a major release like 2.x? I'm not sure if people expect such a breaker in a minor release, or even worse - in a bug release (like possibly 1.9.3).

Yes that is the plan, we are currently working on version 2.0 and that is the reason for removing the deprecated methods. Changes like that should not be included in the v1 branch.

@indigoxela
Copy link

indigoxela commented Oct 11, 2022

Back to the initial idea - a statement about maintenance.

Maybe nobody realized that Leaflet.draw is seeking a new maintainer? (As an optimist I prefer "seeking new" over "has no".) 😉

This project is used by 4k+ other projects, has 1.8k stars and 103 watchers. It's totally possibly that someone volunteers to do some basic update and maintenance work just to keep their own (depending) project running. Currently it probably doesn't require too much work to keep it compatible with a recent Leaflet core. 🤞

@torrid33
Copy link

Oh boy... just integrated leaflet.draw on a major project... now very nervous...

@y1324
Copy link

y1324 commented Apr 11, 2024

we are currently working on version 2.0

Does the 2.0 version refer to 'lefaet'? And are there any plans or to-dos for the 2.0 version currently? I would like to know about the progress, and if it's possible for me to get involved in the development of the 2.0 version.

@Falke-Design

@indigoxela
Copy link

To get Leaflet.draw working with the most recent Leaflet, I had to add some overrides.

I'll probably (have to) do something similar for Leaflet 2.0 to keep my integration up and running, but it looks feasible.
I'd still prefer some maintenance on Leaflet.draw (instead of working around compatibility problems in integrations), if that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants