Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accessibility] Fullscreen control should have role="button" #110

Open
Malvoz opened this issue Feb 20, 2020 · 1 comment · May be fixed by #114 or #118
Open

[accessibility] Fullscreen control should have role="button" #110

Malvoz opened this issue Feb 20, 2020 · 1 comment · May be fixed by #114 or #118

Comments

@Malvoz
Copy link
Member

Malvoz commented Feb 20, 2020 •
edited

For consistency with the other controls:
https://github.com/Leaflet/Leaflet/blob/bdd7ebf836201550f6d173943b728098b83f40d5/src/control/Control.Zoom.js#L89-L91
@Malvoz Malvoz linked a pull request Aug 24, 2020 that will close this issue
Open
2 tasks
@Malvoz Malvoz changed the title Fullscreen "button" should have role="button" [accessibility] Fullscreen "button" should have role="button" Dec 1, 2020
@Malvoz Malvoz mentioned this issue Mar 29, 2021
Open
@Malvoz Malvoz changed the title [accessibility] Fullscreen "button" should have role="button" [accessibility] Fullscreen control should have role="button" Apr 3, 2021
hswong3i added a commit to drustack/Leaflet-Leaflet.fullscreen that referenced this issue Nov 26, 2021
@hswong3i
Rework Legacy PNG Icons with Font Awesome SVG
f9e5a05 
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@hswong3i hswong3i linked a pull request Nov 26, 2021 that will close this issue
Open
hswong3i added a commit to drustack/Leaflet-Leaflet.fullscreen that referenced this issue Nov 30, 2021
@hswong3i
Rework Legacy PNG Icons with Font Awesome SVG
e002bf1 
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
@Malvoz
Copy link
Member Author

Malvoz commented Apr 4, 2022 •
edited

Other potentially helpful resources:

runette pushed a commit to runette/Leaflet.fullscreen that referenced this issue May 13, 2022
@hswong3i
Rework Legacy PNG Icons with Font Awesome SVG
27056dc 
Existing implementation handle icon with PNG, with manual positioning
with CSS background image.

This PR rework icons with Font Awesome SVG:

  - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and
    `compress-solid.svg`
  - Rework styling with SCSS
  - Fix accessibility (see Leaflet#110)
  - Test with Leaflet v1.7.1
  - Update demo with above changes

Fix Leaflet#98
Fix Leaflet#102
Fix Leaflet#103
Fix Leaflet#110
Fix Leaflet#114

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Malvoz