Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in workflow are failing #7824

Closed
Falke-Design opened this issue Nov 28, 2021 · 5 comments · Fixed by #7856
Closed

Tests in workflow are failing #7824

Falke-Design opened this issue Nov 28, 2021 · 5 comments · Fixed by #7856
Labels
workflow Anything related to Leaflet development process and tools

Comments

@Falke-Design
Copy link
Member

I don't know why but tests are often failing because the browser didn't start:
grafik

@jonkoops @mourner Can we change something to fix this? Is it possible to run the tests on the contributer repo, so they can re-start the workflow?

@Falke-Design Falke-Design added the workflow Anything related to Leaflet development process and tools label Nov 28, 2021
@johnd0e
Copy link
Collaborator

johnd0e commented Nov 29, 2021

It's possible to re-run the test manually. At least I have enough permissions and see such button.

@johnd0e johnd0e closed this as completed Nov 29, 2021
@Falke-Design
Copy link
Member Author

Yes I know that you can do this, but others like me can't. Instead of hoping that you re-start the workflow manually, it would be good to check if we can prevent it from failing.

@johnd0e
Copy link
Collaborator

johnd0e commented Nov 29, 2021

if we can prevent it from failing.

But we can't

@jonkoops
Copy link
Collaborator

Yeah, this is flaky but seems like it would be quite hard to fix, if it can really be fixed at all. We could try upping the retry count and timeout direction.

@Falke-Design
Copy link
Member Author

Falke-Design commented Dec 10, 2021

@jonkoops I searched a little bit around and that is what I found:

Many posts are speaking of the Browser binary path is wrong, but I don't know if we have access to this: link 1, link 2

A other attempt would be to increase the timeout: doc, link 3, link 4

Or increase the retry count: doc-retryLimit

Maybe it can be fixed with: browserSocketTimeout

I reopen this, because I think we should try if we can fix it with one of the suggested ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow Anything related to Leaflet development process and tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants