We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I don't know if this is a bug of this library or of cypress. I didn't found an explanation why this is like them.
My onStart function never called in the fingerIsBusy() function because it checks if it is an instance of Function.
onStart
fingerIsBusy()
if (this._onStart && this._onStart instanceof Function) { this._onStart(this); }
My code:
var hand = new Hand({ timing: 'frame', onStart: function () { console.log('TEST') } }); var toucher = hand.growFinger('mouse'); toucher.moveTo(300, 280, 0) .down().moveBy(5, 0, 20).moveBy(256, 32, 1000).wait(100).up().wait(100);
I debugged the code: _onStart is a function because I can call this._onStart() but this._onStart instanceof Function returns false.
_onStart
this._onStart()
this._onStart instanceof Function
false
Because of this bug the onStart and onStop function is never called.
onStop
Maybe it would be better if it changed to typeof this._onStart === "function"
typeof this._onStart === "function"
Versions: "prosthetic-hand": "^1.3.1" "cypress": "^3.8.3"
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I don't know if this is a bug of this library or of cypress. I didn't found an explanation why this is like them.
My
onStart
function never called in thefingerIsBusy()
function because it checks if it is an instance of Function.My code:
I debugged the code:
_onStart
is a function because I can callthis._onStart()
butthis._onStart instanceof Function
returnsfalse
.Because of this bug the
onStart
andonStop
function is never called.Maybe it would be better if it changed to
typeof this._onStart === "function"
Versions:
"prosthetic-hand": "^1.3.1"
"cypress": "^3.8.3"
The text was updated successfully, but these errors were encountered: