Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dangerously_pass_through_form_requests to support extractor-based classical forms? #11

Open
LeoniePhiline opened this issue Nov 25, 2022 · 1 comment

Comments

@LeoniePhiline
Copy link
Owner

Library users will be responsible for making sure CSRF checks are performed from form data. (Consuming the body is necessary for classic, formdata-based CSRF protection.)

@LeoniePhiline
Copy link
Owner Author

LeoniePhiline commented Nov 29, 2022

Much better:
Rather implement a second middleware which actually intercepts form requests (digesting the request body for form-Content-Type non-safe request methods),
and injects hidden token fields into all forms found in the response HTML.

This causes some indirection and might not be the very fastest, but the most secure way.

@LeoniePhiline LeoniePhiline changed the title Add dangerously_pass_through_form_requests to support extractor-based classical forms Add dangerously_pass_through_form_requests to support extractor-based classical forms? Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant