Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support https://github.com/AscendingCreations/AxumSession #29

Open
LeoniePhiline opened this issue Nov 22, 2023 · 2 comments
Open

Comments

@LeoniePhiline
Copy link
Owner

As the lockable axum-sessions is discontinued and tower-sessions is broken by design in concurrent contexts, support axum_session behind a feature flag, or even as default feature.

@maxcountryman
Copy link

tower-sessions is broken by design in concurrent contexts

This is no longer correct.

I would encourage you to reevaluate tower-sessions as it is now the most popular session crate in the tower ecosystem. Many folks are using it to good effect in large projects and it has replaced axum-sessions for all practical intents and purposes.

If you choose not to use it, that's perfectly fine by me but at the same time it is important to understand that it works well in (and in fact is designed for) concurrent contexts.

We'd love your feedback on the crate's discussion forum if you've encountered issues with the latest release and of course welcome contributions from folks in the community.

@LeoniePhiline
Copy link
Owner Author

LeoniePhiline commented Feb 14, 2024

@maxcountryman Thanks for your comment. I will be sure to re-evaluate tower-sessions.

I have recently started a new green-field project at work, and choosing a session manager is one of the next items on my list. I will upgrade axum-csrf-sync-pattern to axum 0.7 and make it compatible with the chosen session manager (or maybe with both, if time allows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants